karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
204 stars 16 forks source link

Upgrade NUnit to 4.0 #2150

Open andy840119 opened 1 year ago

andy840119 commented 1 year ago

image

Will have lots of api breaking change after upgrade to nunit 4.0 Some methods moved to LegacyAssert.

see: https://docs.nunit.org/articles/nunit/release-notes/breaking-changes.html#nunit-40

Before start upgrade the nunit, maybe should finish at least one:

andy840119 commented 1 year ago

Maybe we should use Assert.That(value, condition) instead?

see: https://github.com/nunit/nunit/issues/2437

andy840119 commented 8 months ago

And note that upgrade might have lots of similar breaking changes. Maybe it's time to try Grit