search

karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
204 stars 16 forks source link

Switch the stage to command pattern #2294

Closed andy840119 closed 1 month ago

andy840119 commented 1 month ago

Currently, each stage has it's own applier, and it can directly change the property from drawable lyric.

The final goal is able to generate the command from each stage type. And use another general way(e.g. maybe create stage runner?) to run those command.

https://app.affine.pro/workspace/40306a8a-6c73-4c99-a961-4f928980ef42/uso65AOQC3Hhn3Fs7wh8n Here's the new structure/working flow for the stage.

Image And this PR is focus on the first migration part.

andy840119 commented 1 month ago

Mark as a part of #2090

andy840119 commented 1 month ago

Implemented.