Correct way to add/update opcodes?

karashiiro / MachinaServer

A simple Machina wrapper to send segments to an HTTP server for easy IPC.

GNU General Public License v3.0

13 stars 9 forks source link

Correct way to add/update opcodes? #62

Closed p-doyle closed 3 years ago

p-doyle commented 3 years ago

Hello. I am looking to update an opcode and possibly add a new one. I thought the Sapphire project was the correct place to do that but it seems that their ipcs.h is only up to 5.35. Should I open a PR on this project instead or..?

karashiiro commented 3 years ago

Feel free, not sure why Sapphire wouldn't accept it, though. To my knowledge their code doesn't need to target a particular game version, since they haven't needed to do updates for any version before 5.3.

But anyways, feel free to PR it here.

karashiiro commented 3 years ago

Referencing https://github.com/SapphireServer/Sapphire/pull/705#issuecomment-757334142

p-doyle commented 3 years ago

Okay thanks. Yeah that confused me as well.