search

karashiiro / TextToTalk

Chat TTS plugin for Dalamud. Has support for triggers/exclusions, several TTS providers, and more!
MIT License
45 stars 30 forks source link

Initial implementation of voice file output. #203

Closed Cidan closed 3 months ago

Cidan commented 3 months ago

Fixes #202

Cidan commented 3 months ago

This is the initial implementation, and there's pretty much nothing I like about this change. It feels like a quick hack, so I'm going to rethink this one. I'm also second-guessing it's utility, as externally, there's no good way to extract voice data, apply a DSP, then play it, without the wealth of tooling in the game client.

karashiiro commented 3 months ago

I'm also second-guessing it's utility, as externally, there's no good way to extract voice data, apply a DSP, then play it, without the wealth of tooling in the game client.

Yeah this is also a problem, since you'd presumably want to mute the in-game line for this, and that's a whole other discussion

karashiiro commented 3 months ago

From a UX perspective, I'd actually say that should maybe be its own plugin, unless it were to also apply to TTT's TTS.

Cidan commented 3 months ago

From a UX perspective, I'd actually say that should maybe be its own plugin, unless it were to also apply to TTT's TTS.

Yeah, I came to that conclusion as well about 2 hours ago while mulling this over. It would actually be even better to just implement a DSP in C# and configure the whole thing in-game. I'll toy around with it. I'm going to close this PR as it's clear this isn't the form nor function that should be taken for this.