The Actor-Condition-Resistance-Skills can prevent positive effects

[GoogleCodeExporter]

Currently the implementation of the Actor-Condition-Resistance-Skills can 
prevent positive effects for the player.

a) Someone casts a positive active condition (like a heal) on the player.
(The chance that the player gets healed would be reduced.)
b) The player casts a negative active condition (like minor fatigue) on a 
monster.
(The chance that the monster gets minor fatigue would be reduced.)

Oskar replied:
> Positive effects done by monster attacks is nothing we have now, and
> I doubt that monster attacks will induce positive effects in the future.

Perhaps Part (a) is unlikely to happen.

But r165 introduced the Chaosreaper:
http://andors.techby2guys.com/viewtopic.php?f=2&t=703

With it equipped Part (b) should be possible.

Original issue reported on code.google.com by SamuelPl...@gmail.com on 6 Oct 2011 at 6:51

[GoogleCodeExporter]

I fail to see how the situation you describe could happen with the Chaosreaper. 

CombatController::applyAttackHitStatusEffects calls 
ActorStatsController::applyUseEffect with source={player} and target={monster}.
The Chaosreaper has some conditions attached to "addedConditions_target", which 
are applied by "rollForConditionEffect(target, e)", where "target" in this case 
is the monster. rollForConditionEffect has a check that only applies the chance 
bias if the target is the player.

Original comment by oskar.wi...@gmail.com on 7 Oct 2011 at 7:41

[GoogleCodeExporter]

Ok thank you for the explanation. I obviously confused something.
So currently only (a) could happen.

Could be closed.
Sorry.

Original comment by SamuelPl...@gmail.com on 7 Oct 2011 at 8:24

[GoogleCodeExporter]

No worries.

Case (a) is unlikely to be an issue. Positive effects, if introduced in the 
future, should probably be rewarded by NPCs in some conversation-like 
interface, and not while in combat.

Closing issue.

Original comment by oskar.wi...@gmail.com on 7 Oct 2011 at 9:04

• Changed state: WontFix