karlb / wikdict-web

Web front end for WikDict dictionaries
https://www.wikdict.com
MIT License
16 stars 2 forks source link

[rfc] Minimal effort restyle for more "personality" #17

Closed hartwork closed 3 years ago

hartwork commented 3 years ago

Hi @karlb there's a chance that orange is not your favorite color and that you won't like the look below as of yet — that's okay.

Here's what this few-minutes pull request brings for a demo:

united_demo

In essence, what I have done here is:

What do you think about this direction and its pieces?

Best, Sebastian

hartwork commented 3 years ago

@karlb any thoughts?

karlb commented 3 years ago

I wanted to get today's design changes of the results page out of the way before really thinking about this. I haven't tried it yet (only looked at the screenshots). I prefer to err on the side of being boring rather than being too flashy, so at a first glance I don't see the orange as an improvement. Similarly for the added boxes, I would prefer to use grouping and whitespace to build structure rather than adding more boxes (although I must admit today's update didn't move into that direction either; but I really tried before going that route).

I'll take some time and try it locally at a later time.

hartwork commented 3 years ago

Hi @karklb,

the orange is not really key here, it's just some non-default color. Since I haven't convinced you with the screenshot, I'll give up here, save your and my time, and respect your current choices. I will close the pull request now to keep my own listing at https://github.com/pulls tidy.

Best, Sebastian