search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
300 stars 107 forks source link

Fail to build with -Werror=format-security #385

Closed marillat closed 1 year ago

marillat commented 1 year ago

Build fail under Debian.

I submitted a PR #384 to fix src/client.c But I don't know for src/slave.c Maybe a mistake ?

slave.c:1649:13: error: format not a string literal and no format arguments [-Werror=format-security]
 1649 |     DEBUG0 (msg);
      |             ^~~
logging.h:49:67: note: in definition of macro ‘DEBUG0’
   49 | #define DEBUG0(y) log_write(errorlog, 4, CATMODULE "/", __func__, y)
      |                                                                   ^
cc1: some warnings being treated as errors
karlheyes commented 1 year ago

verified, looks like I should verify with clang as well. I don't think these were actual problem in use but I've committed fixes for these. Thanks.

karl