karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
300 stars 107 forks source link

Issue when connecting with wrong password #394

Closed Daniel-Noethen closed 1 year ago

Daniel-Noethen commented 1 year ago

Hello,

before commit e2d64cd the server answered with the following message when connecting with a wrong password using the PUT method.

HTTP/1.1 100 Continue

HTTP/1.1 401 Authentication Required
Connection: Close
Date: Wed, 01 Feb 2023 16:28:52 GMT
Content-Type: text/html
WWW-Authenticate: Basic realm="Icecast 2.4.0-kh17"
Content-Length: 0

Now since e2d64cd the server answers with

HTTP/1.1 100 Continue
Date: Wed, 01 Feb 2023 16:26:42 GMT
Content-Type: text/html
Content-Length: 0

The line HTTP/1.1 401 Authentication Required is missing which confuses my clients.

Is this behaviour intended?

Best, Daniel

karlheyes commented 1 year ago

intended no. I'll fix shortly, the 1xx codes have to be treated differently, so I just need to flush out the specs on that.

karl

karlheyes commented 1 year ago

should be fixed now in master tree

Daniel-Noethen commented 1 year ago

I can confirm. Thanks again!