search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
297 stars 105 forks source link

kh20.4: Browser tries to download XSL file when loading stats, rather than display it #410

Closed Nick6489 closed 7 months ago

Nick6489 commented 1 year ago

This issue publicly exhibits itself on this server. I recognize that KH20.5 is out, but I can't tell by the changelog if this was fixed?

karlheyes commented 1 year ago

this looks like stale information hanging around in the xsl cache. An xspf disposition header for the status xsl. Can you get a level 4 log from this? Do you have many xsl links requested, even of they are missing?

karl

karlheyes commented 1 year ago

just to clarify, there was a fix post 20.4 that resolved the filename aspect in the disposition, that may be a factor here

karl

Nick6489 commented 1 year ago

I have just updated. I will check back in about two weeks, the last time I updated the thing it took that long for it to exhibit the issue.

Nick6489 commented 1 year ago

SO after updating, it's still doing it. Does sighup change the log level or do I have to restart the whole server? This is the log data it currently shows from a request I make to get the web page.``2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET / HTTP/1.1" 200 763 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /style.css HTTP/1.1" 200 6409 "https://listen.hkcradio.com/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /statusbar.html HTTP/1.1" 200 1330 "https://listen.hkcradio.com/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /status.xsl HTTP/1.1" 200 3913 "https://listen.hkcradio.com/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /style.css HTTP/1.1" 200 6409 "https://listen.hkcradio.com/statusbar.html" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /images/corner_bottomleft.jpg HTTP/1.1" 200 8424 "https://listen.hkcradio.com/style.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /images/corner_bottomright.jpg HTTP/1.1" 200 8415 "https://listen.hkcradio.com/style.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /images/icecast.png HTTP/1.1" 200 5333 "https://listen.hkcradio.com/style.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /images/corner_topleft.jpg HTTP/1.1" 200 8409 "https://listen.hkcradio.com/style.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /images/corner_topright.jpg HTTP/1.1" 200 8411 "https://listen.hkcradio.com/style.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0 2600:4040:9474:d900:101b:dd7c:5e6b:d6db - - [04/Apr/2023:12:14:42 +0000] "GET /favicon.ico HTTP/1.1" 200 1681 "https://listen.hkcradio.com/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36" 0

karlheyes commented 1 year ago

I've reworked the xsl caching code to split the locking some more as there were some race issues there. It looks to be much better now in the master tree.

karl

Nick6489 commented 1 year ago

Once again, I've updated. I will get back to you in a week if it doesn't work (the issue does have some lag time to exhibit).