Closed webben-de closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
Thanks, could you please change the commit message to follow our convention?
sure, like that? I'm not really sure, how to edit the body of the commit.
CLAs look good, thanks!
@geisslercom reset the branch and do your changes with correct commit messages again.
@geisslercom you can use git commit --amend
to change the message of the last commit
Afterwards you'll need to git push -f <remote> <branchname>
@geisslercom one more thing, looks like there is merge conflict now. Could you rebase onto the latests master please (git fetch <remote> && git rebase <remote>/master
)
so the dependence is not longer deprecated