search

karma-runner / grunt-karma

Grunt plugin for Karma.
MIT License
468 stars 116 forks source link

Grunt failing #184

Closed paladox closed 8 years ago

paladox commented 8 years ago

21:42:49 npm ERR! peerinvalid Peer grunt-karma@0.12.1 wants grunt@0.4.x

This happends when using 1.0 grunt.

paladox commented 8 years ago

@dignifiedquire or @vladikoff hi could you update https://github.com/karma-runner/grunt-karma/blob/master/package.json#L49

Change it to 0.4.0 not 0.4.x since it fails https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/35776/console

Reason I'm not doing a pull request is because you have to sign the cla

paladox commented 8 years ago

And release 0.12.3 please.

elicwhite commented 8 years ago

This is currently causing failures with grunt 1.0 now that it has been released.

dignifiedquire commented 8 years ago

The latest version is 0.12.2 which has the correct peerDependency: https://github.com/karma-runner/grunt-karma/blob/master/package.json#L49

vladikoff commented 8 years ago

Yay!

On Wed, Apr 6, 2016 at 9:41 AM, Friedel Ziegelmayer < notifications@github.com> wrote:

The latest version is 0.12.2 which has the correct peerDependency: https://github.com/karma-runner/grunt-karma/blob/master/package.json#L49

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/karma-runner/grunt-karma/issues/184#issuecomment-206378521

paladox commented 8 years ago

Thanks, yep it works.