search

karma-runner / karma-browserstack-launcher

A Karma plugin. Launch any browser on BrowserStack!
MIT License
150 stars 82 forks source link

Config option `tunnelIdentifier` has no effect #155

Closed csvn closed 4 years ago

csvn commented 5 years ago

Issue

The README.md says that tunnelIdentifier can be set to select the localIdentifier for the Browserstack Local connection. But the code clearly shows that this setting is not used or passed to browserstack-local. I think this was broken in ea4ec78352d8829742ae3e96b42944f96d0174e8.

Due to this, we can't set a specific ID in the browser capabilities (e.g. capabilities['browserstack.localIdentifier'] = 'xxx'), because it's randomly created inbrowserstack-local`.

Our use case

We have a two CI jobs for tests, with different configurations. Both starts a Karma separately, but with different browsers setup and script bundling configuration. The issue is that one job keeps having jobs that says e.g. "Firefox 61.0 (Windows 10) has not captured in 60000 ms, killing.". I'm pretty sure this is with multiple Browserstack Local connections, they end up

zarahzachz commented 5 years ago

@csvn Any progress on this? My team is now experiencing the same problem ("Firefox 61.0 (Windows 10) has not captured in 60000 ms, killing.") for all our supported browsers.

csvn commented 5 years ago

@zarahzachz I've made a PR at #158, and we are currently running my fork via npm ("karma-browserstack-launcher": "csvn/karma-browserstack-launcher#fix-configuration-options",). The maintainers need to look at the PR, merge, and release. I have nothing to add to my PR currently 🤷‍♂