search

karma-runner / karma-browserstack-launcher

A Karma plugin. Launch any browser on BrowserStack!
MIT License
150 stars 82 forks source link

fix: make configuration options work again #158

Closed csvn closed 4 years ago

csvn commented 5 years ago

This MR will again pass in the config options tunnelIdentifier, localIdentifier and forceLocal to the npm package that creates the Browserstack Local tunnel.

Resolves #155 #156

csvn commented 5 years ago

I tested this by replacing karma-browserstack-launcher with the Github branch as version in package.json, and it made our pipelines pass once again.

csvn commented 4 years ago

Rebased in latest changes from this repo. Wanted to make sure Travis build does not fail.

michaelfarrell76 commented 4 years ago

when will the next version be published? we were relying on this branch on our CI

csvn commented 4 years ago

@michaelfarrell76 Sorry! I didn't know anyone else was using my branch. You can probably use "github:karma-runner/karma-browserstack-launcher#master" (or commit hash instead of master) instead until the release, right? Also curious when next publish will be, will be nice to get rid of github version links.

michaelfarrell76 commented 4 years ago

yep we did that :) appreciate your help!