karma-runner / karma-browserstack-launcher

A Karma plugin. Launch any browser on BrowserStack!
MIT License
150 stars 82 forks source link

Prevent addition of phantom timeout #160

Open elijms opened 5 years ago

elijms commented 5 years ago

Issue

Occasionally, the worker registers a status of "running" after a test has been killed, and thus adds a phantom timeout. This prevents the addition of said phantom timeout.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

elijms commented 5 years ago

@googlebot I signed it!

XhmikosR commented 3 years ago

@johnjbarton I wonder if this has to do with the random timeouts issue?