search

karma-runner / karma-chrome-launcher

A Karma plugin. Launcher for Chrome and Chrome Canary.
MIT License
469 stars 119 forks source link

fix(Mac WebGL): Allow headless to use GPU #269

Open elalish opened 1 year ago

elalish commented 1 year ago

Fixes #263

Replacing #266.

pmvald commented 1 year ago

Again, commit message error. Almost all the PRs have this problem! It should be fix: allow headless to use GPU - this formatting is needed for release workflow to generated changelist and version automatically.

elalish commented 1 year ago

Maybe time to remove the commitlint test? Especially since I don't think Github's web editor allows one to change the commit message...

pmvald commented 1 year ago

The commit formats have to follow that format in order for semantic release tool to create correct changelogs and version. The commit message can be changed by author. You can just go git reset --soft HEAD~1 && git commit -c ORIG_HEAD && git push --force-with-lease or use git rebase -i HEAD~1. Btw, I imagine this commit message format should be pretty common since most repos these days use this semantic release tool or similar tools and these tools usually follow the angular message formatting. We also mentioned this in our contributing guidelines.