search

karma-runner / karma-jasmine

A Karma plugin - adapter for Jasmine testing framework.
MIT License
542 stars 163 forks source link

silently skipped test suite #191

Open kjjain77 opened 6 years ago

kjjain77 commented 6 years ago

I forgot to unregister a plugin in an afterAll, the next suite to run after that threw: Uncaught TypeError: Cannot read property 'result' of undefined at isAfterAll (jasmine.js:4876) at Suite.onException (jasmine.js:4839) at Suite.onException (jasmine.js:4851) at QueueRunner.onException (jasmine.js:5089) at onException (jasmine.js:4084) at jasmine.js:4056 This caused the whole suite to not run (silently) as in 200 of 242 tests run success returned by karma.

I've fixed the root cause, but a) why does the suite not run/spit out any skip/failure b) how can I force a similar issue to throw an error?

ericcarino commented 6 years ago

@kjjain77 What version are you using? When I updated my project to 1.1.1, I'm now seeing a test fail. It's failing as it should be, but when I roll back to 1.1.0, the test appears to pass just fine.

Possibly the issue you're reporting was fixed in 1.1.1?