search

karma-runner / maven-karma-plugin

Maven plugin for running tests using Karma.
Apache License 2.0
45 stars 26 forks source link

Allow the working directory to be specified. #14

Closed khirakawa closed 11 years ago

khirakawa commented 11 years ago

The maven-karma-plugin will fail to run karma if the karma execution is configured to happen in a submodule. This is because maven tries to invoke karma at the top-level directory, where node_modules does not exist. node_modules only exists in the sub-directory, where the submodule is defined.

I've fixed this by setting the working directory of builder to be the directory of the submodule. By default, this is ${basedir}, but it can be overrided in config.

Thanks!

Ken

kelveden commented 11 years ago

Yep, hadn't considered the scenario when karma was installed locally as opposed to globally.

kelveden commented 11 years ago

Thanks for the commit - I'll get it pushed up to Maven Central in the next few days hopefully.

khirakawa commented 11 years ago

Awesome, thanks for the quick response!

kelveden commented 11 years ago

Released to Maven Central as v1.5. Should be up in the next few hours.

khirakawa commented 11 years ago

Awesome, thanks!

On Wed, Sep 25, 2013 at 4:16 PM, kelveden notifications@github.com wrote:

Released to Maven Central as v1.5. Should be up in the next few hours.

Reply to this email directly or view it on GitHub: https://github.com/karma-runner/maven-karma-plugin/pull/14#issuecomment-25120981