search

karma-runner / maven-karma-plugin

Maven plugin for running tests using Karma.
Apache License 2.0
45 stars 26 forks source link

Skip if no tests? #18

Closed matthughes closed 10 years ago

matthughes commented 10 years ago

I think this is a Karma but, not maven-karma-plugin, but I'm not sure.

Karma definitely will bomb if you try and run it with no tests. Tough I'm not sure how this plugin could address the issue as the files are specified in karma.conf.js.

I created an issue on karma (https://github.com/karma-runner/karma/issues/926) but would be interested in your thoughts.

kelveden commented 10 years ago

Yeah, I think you're best off dealing with this from the karma end - as you say it's all about the karma.conf.js. The plugin just shells out to that. You could perhaps cite the maven-surefire-plugin in your discussion with Vojta - it has a "failIfNoTests" flag. I'm not saying that that's "the right" way to go but at least there is a precedent of what you're after in a well-used plugin.

Am closing this issue.