karma-runner / maven-karma-plugin

Maven plugin for running tests using Karma.
Apache License 2.0
45 stars 26 forks source link

Should be karma-maven-plugin #20

Closed NateRedding closed 10 years ago

NateRedding commented 10 years ago

The name 'maven--plugin' is actually reserved for plugins coming from Apache. 3rd-party plugins should use '-maven-plugin'. When building the plugin as-is, this error message is received:

[ERROR]
Artifact Ids of the format maven-___-plugin are reserved for
plugins in the Group Id org.apache.maven.plugins
Please change your artifactId to the format ___-maven-plugin
In the future this error will break the build.
kelveden commented 10 years ago

Yes, I've seen that. I've held back on moving across to the convention for a few reasons:

I honestly can't believe that they're going to follow through with their "In the future this error will break the build" threat - it'll break too many existing plugins.

BUT having said all that, I don't feel that strongly about it. I've been moving away from Maven as my default build too for a while so the maven-karma-plugin is something I'm not using much these days. I'm probably going to retire from maintainership of it soon. So, if you're happy to setup and maintain a karma-maven-plugin under the karma-runner project I'll happily talk to Vojta about deprecating the maven-karma-plugin in favour of your plugin.

kelveden commented 10 years ago

No activity on this and I don't plan any so closing.