Update maven-plugin-api

karma-runner / maven-karma-plugin

Maven plugin for running tests using Karma.

Apache License 2.0

45 stars 26 forks source link

Update maven-plugin-api #31

Open moose-byte opened 7 years ago

moose-byte commented 7 years ago

My team has a project that uses maven-karma-plugin. We specify a language level of Java 1.7. There is a warning produced during the build from a dependency deep within our dependency tree.

Warning:java: Supported source version 'RELEASE_6' from annotation processor 'org.sonatype.guice.bean.scanners.index.SisuIndexAPT6' less than -source '1.7'

Current dependency Tree screen shot 2016-10-28 at 3 03 56 pm

SisuIndexAPT6 is the culprit because it specifies SourceVersion.RELEASE_6

The latest maven-plugin-api uses a newer version of this library, which does not specify a language level.

screen shot 2016-10-28 at 3 16 04 pm

Upgrading the dependency allows the library to be run in JVMs greater than 1.6 without warnings.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

moose-byte commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

moose-byte commented 7 years ago

Travis is failing because it could not find a .travis.yml or Rakefile. I don't see these files in the master branch, so I'm not sure how to proceed.