search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.1k stars 798 forks source link

operator cleanup #3581

Closed yanggangtony closed 10 months ago

yanggangtony commented 11 months ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: Do some operator cleanup.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None
codecov-commenter commented 11 months ago

Codecov Report

Merging #3581 (3a28669) into master (218a0b2) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3581   +/-   ##
=======================================
  Coverage   55.86%   55.86%           
=======================================
  Files         216      216           
  Lines       20121    20121           
=======================================
  Hits        11240    11240           
  Misses       8276     8276           
  Partials      605      605
Flag Coverage Ξ”
unittests 55.86% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

calvin0327 commented 10 months ago

/lgtm

/cc @Poor12 @lonelyCZ

yanggangtony commented 10 months ago

πŸ˜‚πŸ˜‚ According @Poor12 's opinion. And these similar question have discussed in https://github.com/karmada-io/karmada/pull/3398.

Using o is more clearer.

So may i changes the options *DeInitOptions to opt *DeInitOptions?

calvin0327 commented 10 months ago

πŸ˜‚πŸ˜‚ According @Poor12 's opinion. And these similar question have discussed in #3398.

Using o is more clearer.

So may i changes the options *DeInitOptions to opt *DeInitOptions?

To be consistent with other components, we can use o as the arg name. options *DeInitOptions -> o *DeInitOptions, I think it's ok.

yanggangtony commented 10 months ago

rebased.

Poor12 commented 10 months ago

/lgtm /approve

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Poor12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[operator/OWNERS](https://github.com/karmada-io/karmada/blob/master/operator/OWNERS)~~ [Poor12] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment