karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.1k stars 798 forks source link

cleanup: genertate the necessary code for federatedhpa and fix typo #3595

Closed jwcesign closed 10 months ago

jwcesign commented 10 months ago

What type of PR is this? /kind cleanup

What this PR does / why we need it:

  1. genertate the necessary code for federatedhpa.
  2. Fix typo

Which issue(s) this PR fixes: Fixes #none

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

jwcesign commented 10 months ago

/assign @XiShanYongYe-Chang

codecov-commenter commented 10 months ago

Codecov Report

Merging #3595 (d2c752f) into master (f0798a8) will decrease coverage by 0.02%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3595      +/-   ##
==========================================
- Coverage   55.85%   55.83%   -0.02%     
==========================================
  Files         216      216              
  Lines       20121    20129       +8     
==========================================
+ Hits        11238    11240       +2     
- Misses       8278     8284       +6     
  Partials      605      605              
Flag Coverage Δ
unittests 55.83% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Poor12 commented 10 months ago

/lgtm

Poor12 commented 10 months ago

/cc @RainbowMango

3589 depends on it for testing.

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment