karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.05k stars 790 forks source link

add chart lint ci step for karmada-operaoter chart #3596

Closed CoderTH closed 10 months ago

CoderTH commented 10 months ago

What type of PR is this? /kind feature

What this PR does / why we need it: In this pr https://github.com/karmada-io/karmada/pull/3524, the chart karmada-operaoter is introduced and the chart lint ci step is missing

Which issue(s) this PR fixes: Fixes #3579

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
calvin0327 commented 10 months ago

@Poor12 /cc

codecov-commenter commented 10 months ago

Codecov Report

Merging #3596 (e94bdc6) into master (401a675) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3596   +/-   ##
=======================================
  Coverage   55.83%   55.83%           
=======================================
  Files         216      216           
  Lines       20129    20129           
=======================================
  Hits        11240    11240           
  Misses       8284     8284           
  Partials      605      605           
Flag Coverage Δ
unittests 55.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Poor12 commented 10 months ago

/lgtm /approve

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Poor12, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
RainbowMango commented 10 months ago

Thanks @CoderTH and welcome to Karmada community~