search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.1k stars 800 forks source link

karmada-metrics-adapter only handles clusters in Push mode #3602

Closed chaunceyjiang closed 10 months ago

chaunceyjiang commented 10 months ago

What type of PR is this? /kind bug

What this PR does / why we need it:

image

image

karmada-metrics-adapter only handles clusters in Push mode

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
chaunceyjiang commented 10 months ago

/cc @jwcesign @Poor12

codecov-commenter commented 10 months ago

Codecov Report

Merging #3602 (b47aa07) into master (1e7ab93) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3602      +/-   ##
==========================================
- Coverage   55.83%   55.82%   -0.01%     
==========================================
  Files         216      216              
  Lines       20129    20129              
==========================================
- Hits        11240    11238       -2     
- Misses       8284     8286       +2     
  Partials      605      605
Flag Coverage Δ
unittests 55.82% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

jwcesign commented 10 months ago

/lgtm

cc @RainbowMango for checking.

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment