karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.1k stars 802 forks source link

override verifies that the data is correct #3604

Closed Michael754267513 closed 1 month ago

Michael754267513 commented 10 months ago

When using plaintext to rewrite the data in different clusters, when the patch format is incorrect, the override format is directly returned and the application is not allowed to be applied to the cluster

  overriders:
    plaintext:
      - path: "/spec/template/spec/containers/0/env/0"
        operator: replace
        value:
          foo: bar
LronDC commented 10 months ago

Hi, could you please add some details of this?

Like, how to reproduce it, or the behavior excerpt of your env? Thanks.

Michael754267513 commented 10 months ago

jsonpatch is the wrong path or format, and then override is applied, and then deployment distribution has problems, you should check whether override is correct before, otherwise it will affect the corresponding resource distribution and update.

apiVersion: policy.karmada.io/v1alpha1 kind: OverridePolicy metadata: name: frontend-v1 namespace: automation spec: resourceSelectors:

RainbowMango commented 10 months ago

Can you share the yaml of the Deployment(frontend-v1)? So that, we can reproduce it?

XiShanYongYe-Chang commented 1 month ago

As a lack of activity, let's close this first, feel free to reopen it if you still need it. /close

karmada-bot commented 1 month ago

@XiShanYongYe-Chang: Closing this issue.

In response to [this](https://github.com/karmada-io/karmada/issues/3604#issuecomment-1976134506): >As a lack of activity, let's close this first, feel free to reopen it if you still need it. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.