search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.1k stars 802 forks source link

Automated cherry pick of #3591: Change the length of modelSortings array for panic of index #3608

Closed sunbinnnnn closed 10 months ago

sunbinnnnn commented 11 months ago

Cherry pick of #3591 on release-1.4.

3591: Change the length of modelSortings array for panic of index

For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed the panic issue in case of the grade number of resourceModel is less than the number of resources.
codecov-commenter commented 11 months ago

Codecov Report

Merging #3608 (f4a3d36) into release-1.4 (bd6a4fe) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           release-1.4    #3608   +/-   ##
============================================
  Coverage        41.44%   41.44%           
============================================
  Files              193      193           
  Lines            17142    17142           
============================================
  Hits              7104     7104           
  Misses            9623     9623           
  Partials           415      415
Flag Coverage Δ
unittests 41.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/modeling/modeling.go 70.95% <100.00%> (ø)
Poor12 commented 10 months ago

/lgtm Please add the release-note together.

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/release-1.4/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment