Closed zishen closed 9 months ago
Merging #3613 (a947eb2) into master (2d22b74) will decrease coverage by
0.01%
. The diff coverage is35.82%
.:exclamation: Current head a947eb2 differs from pull request most recent head 51bbfa0. Consider uploading reports for the commit 51bbfa0 to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #3613 +/- ##
==========================================
- Coverage 55.68% 55.67% -0.01%
==========================================
Files 225 225
Lines 21313 21330 +17
==========================================
+ Hits 11868 11876 +8
- Misses 8813 8820 +7
- Partials 632 634 +2
Flag | Coverage Δ | |
---|---|---|
unittests | 55.67% <35.82%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/util/lifted/corehelpers.go | 7.54% <ø> (ø) |
|
pkg/util/lifted/corev1helpers.go | 27.77% <ø> (+11.11%) |
:arrow_up: |
pkg/util/lifted/corevalidation.go | 37.14% <ø> (ø) |
|
pkg/util/lifted/genutils.go | 78.57% <ø> (ø) |
|
pkg/util/lifted/podtemplate.go | 0.00% <ø> (ø) |
|
pkg/util/lifted/requestinfo.go | 84.61% <0.00%> (-10.29%) |
:arrow_down: |
pkg/util/lifted/resourcename.go | 0.00% <ø> (ø) |
|
...ted/scheduler/framework/parallelize/parallelism.go | 56.25% <ø> (ø) |
|
pkg/util/lifted/taint.go | 91.89% <ø> (ø) |
|
pkg/util/lifted/validateclustertaints.go | 0.00% <0.00%> (ø) |
|
... and 8 more |
/cc @RainbowMango pls take a look.
Thanks, I will take a review ASAP.
some thing go wrong. Can you help me to retry it? @RainbowMango
done.
/lgtm /approve
cc @RainbowMango It's ready to go.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango, XiShanYongYe-Chang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this? /kind cleanup
What this PR does / why we need it: For kamarda is based on k8s 1.26, but most lifted files are in 1.23. So we need synchronize files to version 1.26 of k8s.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer: update lifted files to k8s 1.26
Does this PR introduce a user-facing change?: NONE