karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.1k stars 798 forks source link

Add printcolumn for FederatedHPA #3622

Closed Poor12 closed 10 months ago

Poor12 commented 10 months ago

What type of PR is this? /kind api-change

What this PR does / why we need it: Add printcolumn for FederatedHPA

NAME         REFERENCE-KIND   REFERENCE-NAME   MINPODS   MAXPODS   REPLICAS   AGE
nginx-test   Deployment       nginx            1         10        1          5d1h

Unlike the native HPA, FederatedHPA cannot print the target utilization as the limit of CRD. As far as I know, CRD‘s print column only supports definite json path.

The native hpa is like:

NAME         REFERENCE          TARGETS        MINPODS   MAXPODS   REPLICAS   AGE
nginx-test   Deployment/nginx   <unknown>/10   1         10        0          3h59m

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

api-change:  add printcolumn for `FederatedHPA`, including reference, minpods, maxpods and replicas.
codecov-commenter commented 10 months ago

Codecov Report

Merging #3622 (b0dbb9f) into master (cf46126) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3622   +/-   ##
=======================================
  Coverage   55.22%   55.22%           
=======================================
  Files         221      221           
  Lines       20831    20831           
=======================================
  Hits        11504    11504           
  Misses       8717     8717           
  Partials      610      610           
Flag Coverage Δ
unittests 55.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

jwcesign commented 10 months ago

/lgtm

Poor12 commented 10 months ago

/approve

/hold Please update the PR description according to the latest content.

Done.

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
RainbowMango commented 10 months ago

/hold cancel