karmi / retire

A rich Ruby API and DSL for the Elasticsearch search engine
http://karmi.github.com/retire/
MIT License
1.86k stars 533 forks source link

Function score and Indexed terms filter #955

Closed brupm closed 10 years ago

brupm commented 10 years ago

Implements 2 new classes for functionality added to ES 1.0 and greater

karmi commented 10 years ago

Hi Bruno, I'm sorry, but a code change like adding a function_score is precisely what I have in mind when I say that the Tire gem is "retired" and no major new features shold be added to it...

(In addition, I see many unrelated commits under this PR, and I don't see any test coverage.)

karmi commented 10 years ago

Closing this, please ping me if you need to talk about it more.

brupm commented 10 years ago

Actually I never meant to submit this back into karmi/retire, likely a git push mistake. We're keeping our own forked version of tire.