Open vwxyzjn opened 1 year ago
Hi @karpathy this is such an awesome repo. I was implementing it from scratch using JAX and learned quite a bit :)
This PR proposes a more consistent naming convention.
n_embd
embd_dim
head_dim
C // self.n_head
hs
hd
embd_dm
att
attn
tok_emb
tok_embd
embd
embedding
pos_emb
pos_embd
Hi @karpathy this is such an awesome repo. I was implementing it from scratch using JAX and learned quite a bit :)
This PR proposes a more consistent naming convention.
n_embd
->embd_dim
, since we are really splitting theembd_dim
into separate heads, which have their ownhead_dim
C // self.n_head
->head_dim
to give a better namehs
->hd
, to unify naming from "head size" to "head dim", which connects nicely withembd_dm
att
->attn
for consistencytok_emb
->tok_embd
for consistency with usingembd
as an abbreviation forembedding
pos_emb
->pos_embd
for consistency with usingembd
as an abbreviation forembedding