search

kartik-venugopal / aural-player

An audio player for macOS, inspired by Winamp.
MIT License
822 stars 44 forks source link

Audio pan to left with certain FLAC and mp3 files/missing vocals on right channel #19

Closed luvBuzz closed 3 years ago

luvBuzz commented 4 years ago

Hi! Thanks for the great program. Unfortunately I experience weird behaviour with some FLAC and mp3 files.

The audio seems to be off center. The vocals and instruments which should be in the middle are only audible on the left channel. The right channel itself sounds like something is missing, as if you would listen to the sourround channel of a 5.1 system (although the info says 2ch or stereo).

The audio for the said files is fine with IINA.

Appears on Macbook and iMac on different speakers/headphones and audio interfaces.

kartik-venugopal commented 3 years ago

Hi, thanks for reporting this issue.

Yes, I have noticed this behavior too. I have noticed it only with FLAC files, however. Initially, I suspected that it may something to do with the AVAudioEngine framework and the fact that native FLAC support is relatively new to macOS (was introduced only in High Sierra 10.13). I wasn't aware that it also happens with some MP3s.

I did test problem files with VLC and found that VLC handled them fine (probably because it uses AudioUnit, not AVAudioEngine). I suspect that IINA is also using AudioUnit (a lower level framework than AVAudioEngine).

I am currently away from the project for a little while, but I will certainly investigate this further when I return to working on this project.

Cheers.

kartik-venugopal commented 3 years ago

@luvBuzz Hi, is there any way you can share any of the problem files with me so that I can reproduce and try to fix this issue ? I'd really appreciate it.

If not, no worries.

luvBuzz commented 3 years ago

@maculateConception Hi! I've updated to 2.6 and BigSur now and it seems like those .flac files can't be played anymore ("File is not a playable audio track. Is it a valid audio file of a supported format ?"). Unfortunately I can't remember exactly which songs were affected so I'm not a 100% sure. If you could send me a mail adress, i can send you one of those files.

kartik-venugopal commented 3 years ago

Wow, that's a pretty bad bug. My email address is aural.student@gmail.com

Please send me the FLAC file that 2.6 was not able to play. I'll look into that issue first and then try to reproduce the panning issue. Thanks !

By the way, I've released v2.7, which uses ffmpeg to decode FLAC files ... this might fix the panning issues altogether, I'm not sure. Please try v2.7 out with those same FLAC files ... will be interesting to see if that resolves the issue(s).

Version 2.7

luvBuzz commented 3 years ago

I can confirm that v2.7 fixed this issue. The mentioned files are now playable. Just for clarification: I think those same files had the panning issue in the older versions. That is why I think this issue is now solved completely and can be closed.

Great work!

kartik-venugopal commented 3 years ago

Thanks very much for the report on v2.7. Good news.

However, could you please send me the file that 2.6 couldn't play ? I would like to find out why that happened ... knowing that would really help me. If possible, thanks.

I'm closing the issue. Cheers !

EDIT - Got the file. Thanks !