kartoza / LEDET_BIMS

Limpopo Biodiversity Information Management System
GNU General Public License v3.0
1 stars 9 forks source link

GeoNode People page has BIMS header instead of GeoNode header #308

Closed gubuntu closed 5 years ago

gubuntu commented 5 years ago

https://staging.limpopobims.kartoza.com/people

all geonode pages need access to geonode menus

dimasciput commented 5 years ago

This ticket is the opposite of the other ticket which states that we should change the theme for people page to django-bims.

On Sun, 13 Jan 2019 at 16.41 Gavin Fleming notifications@github.com wrote:

https://staging.limpopobims.kartoza.com/people

all geonode pages need access to geonode menus

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kartoza/LEDET_BIMS/issues/308, or mute the thread https://github.com/notifications/unsubscribe-auth/AB40sfZWHb06ueq9RtEF82-b6KbC2wA7ks5vCv8ygaJpZM4Z9Eki .

-- Regards, Dimas Tri Ciputra

gubuntu commented 5 years ago

mmm, no I don't think so. It was the individual profile page (not the 'People' page I don't think) that didn't look good before and needed more integration.

Step back and look at how each page or component works together, to judge whether a ticket makes sense or to ensure a fix works in a bigger context.

if that page still works (navigation-wise, like it would with the GeoNode menu) then it might be OK to keep the BIMS menu...