Extract images even if they all have weights exactly zero

karussell / snacktory

Readability clone in Java

461 stars 159 forks source link

Extract images even if they all have weights exactly zero #62

Closed todvora closed 7 years ago

todvora commented 7 years ago

Fixed a bug in image extraction. If all images in a page have the computed weight exactly 0 (image like <img src="first-image.jpg"/>, no alt, title or dimensions), they were not added to the images list. Due to this condition no element is returned and thus no images added to the list.

Added a test for this use case as well.

Thanks!

karussell commented 7 years ago

Thanks!

todvora commented 7 years ago

Thank you for the merge!