kasei / attean

A Perl Semantic Web Framework
19 stars 10 forks source link

Add GitHub workflow using perlrdf/devops actions #163

Closed zmughal closed 10 months ago

zmughal commented 11 months ago
zmughal commented 11 months ago

Besides the failures due to #164, some of the lines in t/parser_serializer_api.t are duplicated as is() tests when the equivalent like() is there for multiple serializers.


https://github.com/kasei/attean/blob/c43327529f59819b330aa6f6c60b16287349ae38/t/parser_serializer_api.t#L35

https://github.com/kasei/attean/blob/c43327529f59819b330aa6f6c60b16287349ae38/t/parser_serializer_api.t#L40


https://github.com/kasei/attean/blob/c43327529f59819b330aa6f6c60b16287349ae38/t/parser_serializer_api.t#L38

https://github.com/kasei/attean/blob/c43327529f59819b330aa6f6c60b16287349ae38/t/parser_serializer_api.t#L33

zmughal commented 10 months ago

This CI workflow now passes https://github.com/zmughal-contrib/attean/actions/runs/5845450384.

kasei commented 10 months ago

So this is good to merge?

zmughal commented 10 months ago

Yes, it should be ready.