search

katharostech / docker-plugin_lizardfs

Docker volume plugin for mounting LizardFS
Other
19 stars 2 forks source link

Timeout tests are failing #2

Open johny-mnemonic opened 6 years ago

johny-mnemonic commented 6 years ago

Hi @zicklag. I am trying to build this for RPi and everything worked for me so far, till I tried to run tests. All tests actually succeeded, apart of the last two, which are testing timeout for non existing lizardfs cluster. Here is the end of my run-tests.sh: [Plugin Test] Check timeout when connecting to non-existent cluster DRIVER VOLUME NAME lizardfs:latest lizardfs TEST FAILED [Root] All done. Stopping Docker cat: can't open '/run/dockerd-entrypoint.pid': No such file or directory sh: you need to specify whom to kill I am not sure, why it behaves that way, but no matter what I did, docker volume ls always finish under 1s (usually time returns 0.56s). Maybe they changed the behavior in latest docker 18.06 (I am running 18.06.1-ce), I don't know.

The part with missing '/run/dockerd-entrypoint.pid' file is also interesting, as the file is actually visible from inside the running 'test-environment.sh' (where it is created), but apparently not from the docker-entrypoint.sh which tries to use it to kill that dockerd.

zicklag commented 6 years ago

Thanks for the report. I don't actually have a whole lot of time to do much investigation at the moment, but at least it looks like all of the other tests are successful. Maybe it is the docker version. I don't think I tested it with the latest Docker version yet so that could be the issue. It should be harmless as it is just to make sure that you could set a timeout to keep the plugin from stalling Docker.

As for the missing .pid file, when I get the chance to get back to work on the plugin, I'm probably going to rewrite the tests using some kind of bash testing library or something. I think you are still safe to use the plugin. It is more likely an issue with my testing script.

zicklag commented 6 years ago

@johny-mnemonic I just found out another issue with the plugin on Docker 18.06 ( #3 ) with Swarm. You might be fine if you are not using the swarm deployment, but otherwise you may need to use Docker 18.03 until I can find time to refactor the Swarm deployment.