search

kavedaa / sbt-javafx

JavaFX plugin for SBT
36 stars 6 forks source link

No way to specify the fx:application/@version attribute. #10

Closed metasim closed 10 years ago

metasim commented 10 years ago

By default, I think the version attribute in <fx:application version="...."/> should default to the SBT project version. Ideally there would be a way to override that. Currently it is defaulting to 1.0.

As an aside, I'm wondering if there's some elegant way allowing the Ant XML to be processed before writing without exposing too many of the internals.

kavedaa commented 10 years ago

Simeon H.K. Fitch wrote:

By default, I think the |version| attribute in |<fx:application version="...."/>| should default to the SBT project version. Ideally there would be a way to override that. Currently it is defaulting to 1.0.

Is there actually a version attribute? I can't find it in the documentation http://docs.oracle.com/javafx/2/deployment/javafx_ant_task_reference.htm#CIAGCAFH

As an aside, I'm wondering if there's some elegant way allowing the Ant XML to be processed before writing without exposing too many of the internals.

I'm not sure what you mean?

metasim commented 10 years ago

Is there actually a version attribute? I can't find it in the documentation

Looks like an Oracle documentation fail. Here's where it's described:

http://docs.oracle.com/javafx/2/deployment/self-contained-packaging.htm#sthref51

Pull request on it's way...