search

kayleg / cloud-pubsub

Google Cloud PubSub client in rust
MIT License
31 stars 21 forks source link

feature: Add attributes to published EncodedMessage #20

Closed BigJerBD closed 2 years ago

BigJerBD commented 2 years ago

Feel free to ask/do anything with this PR, I'll try to help if I can :)

related issue : https://github.com/kayleg/cloud-pubsub/issues/19

kayleg commented 2 years ago

Should attributes on the EncodedMessage be an Option? From a performance stance, there's no need to allocate and serialize empty options.

Let me know if I'm missing something but otherwise that would be the only change.

BigJerBD commented 2 years ago

Alright I'll do it when I have a little bit of time :)

BigJerBD commented 2 years ago

Update done feel free to review and merge :)