search

kazazor / git-pre-commit

A pre-commit hook that ignores all the unstagged changes while performing the pre-commit command you wrote (Using Shell, Gulp, Grunt etc..)
https://www.npmjs.com/package/git-pre-commit
MIT License
18 stars 5 forks source link

Removing fs dependency as it is part of Node.js core #22

Closed leog closed 8 years ago

leog commented 8 years ago

Apparently the 'fs' package is now part of the npm core, and is no longer required for import. npm/npm#13743

kazazor commented 8 years ago

Thanks @leog for your help :) 1 question - do you know since which version fs is part of npm core? I asking because I'm thinking that maybe this change will require to jump to version 2.0.0 in order to also support npm 2.x.x (node 4 LTS) and not just npm 3.x.x (node 6 soon to be LTS)..

After we'll understand which version to set, I'll merge the PR and update the change log + npm publish..

kazazor commented 8 years ago

I can see that fs is on npm core for a long time.. So it is OK just updating it to 1.0.2

kazazor commented 8 years ago

Thanks for the help!

leog commented 8 years ago

@kazazor just saw your comments here, different timezones as you may know...

That's correct, fs library was always part of Node.js core and there was a reference on the npm registry to it, the thing is that recently, it was removed from the registry so depending on fs explicitly from package.json will throw a not found error.