kazuakiyama / homebrew-difmap

Homebrew formula for the Caltech VLBI Program DIFMAP
8 stars 2 forks source link

Fix for installation on MacOS Ventura #1

Closed WWGolay closed 1 year ago

WWGolay commented 1 year ago

Hi @kazuakiyama, I'm working with @rmutel and ran into issues installing pgplot and difmap on MacOS Ventura (v13.0.1 on MacBook Pro M1). I managed to modify your scripts to allow for installation. The error is primarily due to the make files for both pgplot and difmap handing the C compiler GCC the OS version (seemingly pointlessly). Since the latest version of GCC doesn't understand an input of anything above 12.4.x, it breaks. I made modifications to check the current version and override the appropriate flag if necessary. This shouldn't impact anyone below Ventura. See the pull request on the pgplot repository as well.

Cheers,

WWG

kazuakiyama commented 1 year ago

I merged the request! Sorry that my response is extremely late.

kazuakiyama commented 6 months ago

Just add a note that the revised line with this pull request is being revised in the latest commit based on an issue posted in my PGPLOT formula that we should use MacOS.version macro defined by homebrew. Related Issue: https://github.com/kazuakiyama/homebrew-pgplot/issues/5 A new revision: https://github.com/kazuakiyama/homebrew-difmap/commit/669847a7c44cfc0abb2952573dfb78942162940a