kbeckmann / game-and-watch-retro-go

Emulator collection for Nintendo® Game & Watch™
GNU General Public License v2.0
440 stars 133 forks source link

PCE: Figure out if CYCLES_PER_LINE should be 455 or 228 #167

Closed kbeckmann closed 3 years ago

kbeckmann commented 3 years ago

Included from Core/Src/porting/pce/main_pce.c, CYCLES_PER_LINE is defined to 455 in retro-go-stm32/huexpress-go/components/huexpress/engine/hard_pce.h.

But because of a later include, shared.h -> smsplus/sms.h defines it to 228.

455 seems like the correct value, but I have no clue what this changes.

If anyone knows more about this and wants to test, please go ahead.