search

kblincoe / QualOpt_SE701

2 stars 15 forks source link

Google sign in uses environment for API keys #133

Closed will-molloy closed 6 years ago

will-molloy commented 6 years ago

Solution to #23 follow up PR to #64.

Change: get Google client and secret from environment rather than expose them in this public repository. The keys would then be set at deployment e.g. in Heroku or similar. Need #105 to really test this.

softeng-701 commented 6 years ago

@wilmol please ask your team to review, thanks!

will-molloy commented 6 years ago

@softeng-701 fixed conflict and squashed. Ready for merge :)