search

kblincoe / VisualGit_SE701_2019_3

1 stars 0 forks source link

Logging (with top right sign in button) in with empty fields causes errors #327

Closed ktam069 closed 5 years ago

ktam069 commented 5 years ago

Similar to #317, but for the sign in button at the top right (after continuing without signing in).

To reproduce:

1) open the app 2) continue without log in 3) press the sign in button at the top right 4) press sign in without typing in anything 5) observe that errors are shown in the console / no modal pops up to inform the user that signing in failed

Expected: 1) there should be no errors 2) the user should see some indication that one or more field is empty

dcho415 commented 5 years ago

Approve

PrashamJhaveri commented 5 years ago

approve

Amal97 commented 5 years ago

Approve