kbond / ZenstruckFormBundle

Provides Twitter Bootstrap form theme, a help type extension, Ajax/Tunnel/Select2 entity form types and javascript helpers
25 stars 14 forks source link

Doctrine and DoctrineBundle dependencies #25

Closed maxailloud closed 10 years ago

maxailloud commented 10 years ago

Is there a reason that doctrine and doctrine-bundle dependencies in composer.json follow master branch and not a specific tag?

I'm using ZenstruckFormBundle but I also referenced doctrine and the doctrine-bundle in my composer.json, but with a tagged version.

So when launching composer update I get the master of each package instead of the one I wanted.

So will it problematic if we specify version for doctrine and doctrine-bundle packages?

kbond commented 10 years ago

I don't think this bundle is the problem... The only requirement in composer.json is symfony/symfony: ~2.1

doctrine and doctrine-bundle are dev requirements only

maxailloud commented 10 years ago

But dev requirements are automatically download by composer. I'm developping so I cannot put the --no-dev option to composer, and so I get this packages.

kbond commented 10 years ago

dev requirements are only used at the root level of a project: https://getcomposer.org/doc/04-schema.md#require-dev

if this bundle is a requirement for your project, the dev requirements will not be installed.

maxailloud commented 10 years ago

Oh ok. Wasn't aware about that.

So thanks for the information.

kbond commented 10 years ago

do you have minimum stability set to dev on your project? https://getcomposer.org/doc/04-schema.md#minimum-stability

maxailloud commented 10 years ago

Yes, dev.

kbond commented 10 years ago

that's why you are getting the master branches i think - you should set it to "stable" or remove it (stable is default)

maxailloud commented 10 years ago

Didn't thought about it.

I will give it a try.