kbss-cvut / s-pipes

Tool for execution of RDF-based pipelines.
GNU Lesser General Public License v3.0
4 stars 5 forks source link

Add constants instead of raw values to attribute name in @parameter annotation #258

Closed palagdan closed 14 hours ago

palagdan commented 4 weeks ago

Raw values in attribute name should be changed to constant Screenshot from 2024-08-15 15-01-17

palagdan commented 2 weeks ago

@blcham

We have two options for solving this:

We can add a Property parameter to the @Parameter annotation. This parameter will be optional, allowing users to provide a Property directly instead of using a prefix and name.

Alternatively, we can create a separate file specifically for constants such as replace, value, selects, etc.

blcham commented 2 weeks ago

I believe it does not come with price of adding new dependencies, so i would go with adding Property named e.g. url.

palagdan commented 1 day ago

@blcham

Property is an interface so we cannot add it to the annotation because it requires a constant value in a compile time. So we have only one options to make constants for names(replace , is-parse-text etc).

blcham commented 1 day ago

I suggest to remove urlPrefix and name parameter of @Parameter annotation and instead introduce iri parameter as can be found in initial PR. What do you think?