search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
5 stars 21 forks source link

Fix sharded charts to allow them to render successfully #84

Closed embik closed 6 months ago

embik commented 6 months ago

This is probably not 100% cleaned up yet, but I added the new charts to the chart rendering script we run in CI to validate them. Publishing the last PR failed (see https://github.com/kcp-dev/helm-charts/commit/6c14e542c6d5ccd49887508e5eeffa8748b9af6f), so we need additional validation.

I found a couple of issues and missing fields in values.yaml of multiple charts that are expected to be there by the templates, so I've added them.

mjudeikis commented 6 months ago

/lgtm /approve

small steps and we will get there

kcp-ci-bot commented 6 months ago

LGTM label has been added.

Git tree hash: 3071711c9214b276c9eea204c0009c44ffe9e22f

kcp-ci-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment