search

kcp-dev / kcp

Kubernetes-like control planes for form-factors and use-cases beyond Kubernetes and container workloads.
https://kcp.io
Apache License 2.0
2.38k stars 383 forks source link

:bug: authorization/delegated: fix typo leading to zero deny cache ttl #3163

Closed sttts closed 2 months ago

sttts commented 2 months ago

Summary

A typo led to a zero ttl for the deny cache of delegated authz.

Related issue(s)

Fixes #

Release Notes

Fix performance problem in virtual workspace authorization.
sttts commented 2 months ago

/approve

kcp-ci-bot commented 2 months ago

@phisco: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kcp-dev/kcp/pull/3163#pullrequestreview-2306221421): >good catch! Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kcp-ci-bot commented 2 months ago

LGTM label has been added.

Git tree hash: b6ae3a89da29a6fce14cae3413890caf9a559983

kcp-ci-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/kcp/blob/main/OWNERS)~~ [embik,sttts] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kcp-ci-bot commented 2 months ago

New changes are detected. LGTM label has been removed.