search

kcp-dev / kcp

Kubernetes-like control planes for form-factors and use-cases beyond Kubernetes and container workloads.
https://kcp.io
Apache License 2.0
2.38k stars 383 forks source link

:bug: admission/webhooks: properly cache webhooks and cleanup #3164

Open sttts opened 2 months ago

sttts commented 2 months ago

Summary

The old code only added webhook sources, but never cleaned up. This PR bump kube to get CEL optimization for webhook filters, and it properly caches the webhook per cluster and cleans up on deletion.

Related issue(s)

Fixes #

Release Notes

Fix memory leak in admission webhook caching.
kcp-ci-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sttts. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kcp-dev/kcp/blob/main/OWNERS)** - **[pkg/admission/OWNERS](https://github.com/kcp-dev/kcp/blob/main/pkg/admission/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sttts commented 2 months ago

/retest

kcp-ci-bot commented 2 months ago

@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-e2e-multiple-runs 6493b39402e00b8460ded0f5b532beb66fab7c35 link true /test pull-kcp-test-e2e-multiple-runs
pull-kcp-test-e2e 6493b39402e00b8460ded0f5b532beb66fab7c35 link true /test pull-kcp-test-e2e
pull-kcp-test-e2e-shared 6493b39402e00b8460ded0f5b532beb66fab7c35 link true /test pull-kcp-test-e2e-shared
pull-kcp-test-e2e-sharded 6493b39402e00b8460ded0f5b532beb66fab7c35 link true /test pull-kcp-test-e2e-sharded

Full PR test history

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).