bugfix: in Python 3.x, msvcrt.getch() return a byte string not a character

kcsaff / getkey

MIT License

41 stars 18 forks source link

bugfix: in Python 3.x, msvcrt.getch() return a byte string not a character #4

Open li-rupert opened 5 years ago

li-rupert commented 5 years ago

commit 79bfdd64e135ecd4bf634a2756b1fd214c390aee should fix issue #1 commit 2c2bf7e2ea673ccbc7fe0bd59678f4bb43ec9523 should fix issue #2 (comes from mtikekar)

mpoush commented 4 years ago

@kcsaff, any possibility on getting this PR merged in?

It fixes at least two issues I've run into when using Python 3:

on Windows, getkey() doesn't work
on macOS, getkey(blocking=False) always returns None