search

kdeldycke / meta-package-manager

🎁 wraps all package managers with a unifying CLI
https://kdeldycke.github.io/meta-package-manager
GNU General Public License v2.0
474 stars 33 forks source link

Fix(flatpak) fix search description with spaces #1391

Closed remigermain closed 1 month ago

remigermain commented 1 month ago

Hey, when you want to install/search a flatpak packages with space in description, it dosen't work :

flatpak search org.gnome.World.Citations --ostree-verbose
Citations       Manage your bibliography        org.gnome.World.Citations       0.7.0   stable  flathub

and mpm can't parse it. And i add --nointeractive flags for install command

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.03%. Comparing base (607b4ba) to head (37483a7). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
meta_package_manager/managers/flatpak.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1391 +/- ## ======================================= Coverage 55.03% 55.03% ======================================= Files 37 37 Lines 3189 3189 Branches 516 516 ======================================= Hits 1755 1755 Misses 1349 1349 Partials 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kdeldycke commented 1 month ago

Good catch. Your new regex is good as we are saved by \t delimiter in the columns, so no worries about potential non-greedy matching side-effects.