search

kdn251 / interviews

Everything you need to know to get the job.
https://www.youtube.com/channel/UCKvwPt6BifPP54yzH99ff1g?view_as=subscriber
MIT License
63.67k stars 12.91k forks source link

added link complete in readme.md #38

Closed jitendra3109 closed 7 years ago

jitendra3109 commented 7 years ago

Fixed issue #35 As of now, work is done. Please review it and merge it. I added the relative link off from readme to direct code.

jitendra3109 commented 7 years ago

@kdn251 Please review it. If need then makes changed according to yours.

jitendra3109 commented 7 years ago

@kdn251 @EugenHotaj Please review and merge it. It has been taken too much time.

EugenHotaj commented 7 years ago

I'll let @kdn251 merge if he's ok with changes.

kdn251 commented 7 years ago

Hi @jsroyal, thanks for the PR. At the moment, the Tree is not up to date. Therefore, I suggest recreating the Tree so that it reflects most up to date version of the repository before adding links!

jitendra3109 commented 7 years ago

Tree is not up to date.

Do you mean by other folder code also want to include? Okay. It's your choice.

kdn251 commented 7 years ago

Yes, there have been new files added and even new directories I believe. Please update the tree first and then add the corresponding links for each file. Thanks!

jitendra3109 commented 7 years ago

Are you talking about interviews/LeetCode this directory or something else?

kdn251 commented 7 years ago

If you look at the current tree it does not have directories like LeetCode, Companies, UVa, etc. The tree should contain these before the links are added. There's a command line tool called Tree that can be used to generate the graphical representation of file structures

jitendra3109 commented 7 years ago

The tree should contain these before the links are added.

Nope, there is nothing like that. can you see that in your master readme file?

Also, send the link of tool to generate directory or you should generate the tree and I will update the link of it.

jitendra3109 commented 7 years ago

@kdn251 Hi! Do you want to all file directory? But as I added in the readme file it goes all the way long. so I think it won't be better. Have you any thought on it or do you want me just add the all link

jitendra3109 commented 7 years ago

Don't get a response from you guys. So I did it. Please review it. Let me know If you want to do something with it.

jitendra3109 commented 7 years ago

Sorry for that redundant comments. Yes! I did remove it . Now you to pretty much for review.

jitendra3109 commented 7 years ago

@EugenHotaj @kdn251 Please review it and merge it. It has been almost a week not even comment on it. Please review and let me know if you want to change something.

keon commented 7 years ago

@jsroyal calm down

jitendra3109 commented 7 years ago

@kdn251 @EugenHotaj @keon May I take down this PR and think about some alternative. What is thought about it?

jitendra3109 commented 7 years ago

Hello Mr. @kdn251 Please update with this PR.